[fix][admin] Fix exception thrown in getMessageId method #23784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
approved these changes
Dec 30, 2024
dao-jun
approved these changes
Dec 30, 2024
BewareMyPower
approved these changes
Dec 30, 2024
@danpi The result of a CompletableFuture doesn't change after it has been set once with |
lhotari
approved these changes
Jan 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23784 +/- ##
============================================
+ Coverage 73.57% 73.91% +0.33%
+ Complexity 32624 31813 -811
============================================
Files 1877 1853 -24
Lines 139502 146748 +7246
Branches 15299 17184 +1885
============================================
+ Hits 102638 108468 +5830
- Misses 28908 29672 +764
- Partials 7956 8608 +652
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
pushed a commit
that referenced
this pull request
Jan 3, 2025
Co-authored-by: houbonan <[email protected]> (cherry picked from commit 1f7a79f)
lhotari
pushed a commit
that referenced
this pull request
Jan 3, 2025
Co-authored-by: houbonan <[email protected]> (cherry picked from commit 1f7a79f)
lhotari
pushed a commit
that referenced
this pull request
Jan 3, 2025
Co-authored-by: houbonan <[email protected]> (cherry picked from commit 1f7a79f)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 7, 2025
Co-authored-by: houbonan <[email protected]> (cherry picked from commit 1f7a79f) (cherry picked from commit b738d14)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 8, 2025
Co-authored-by: houbonan <[email protected]> (cherry picked from commit 1f7a79f) (cherry picked from commit b738d14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23766
Motivation
During the fix of the previous issue, a detail was overlooked, which could lead to the exception being overwritten.
Modifications
Add a return statement after handling the LedgerNotExistException in the readEntryFailed method to ensure that the exception is not overwritten by subsequent code.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: